Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with Parameter mdb overrides only #471

Merged
merged 4 commits into from
Sep 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
* this source code distribution or the Licensing information page available
* at runtime from the About dialog for additional information.
*****************************************************************************/
import { AGGREGATE_TYPE, UNSUPPORTED_TYPE, METADATA_TIME_KEY } from './const.js';
import {AGGREGATE_TYPE, UNSUPPORTED_TYPE, METADATA_TIME_KEY, MDB_CHANGES_PARAMETER_TYPE} from './const.js';
import limitConfig from "./limits-config.json";

function idToQualifiedName(id) {
Expand Down Expand Up @@ -211,12 +211,14 @@ async function getLimitOverrides(url) {
const overrides = await requestLimitOverrides(url);

overrides.forEach((override) => {
const parameterOverride = override.parameterOverride;
const parameter = parameterOverride.parameter;
const alarmRange = parameterOverride?.defaultAlarm?.staticAlarmRange ?? [];

limitOverrides[parameter] = getLimitFromAlarmRange(alarmRange);
if (override.type === MDB_CHANGES_PARAMETER_TYPE) {
const parameter = override?.parameterOverride?.parameter;
const alarmRange = override?.parameterOverride?.defaultAlarm?.staticAlarmRange ?? [];

if (parameter && alarmRange) {
limitOverrides[parameter] = getLimitFromAlarmRange(alarmRange);
}
}
});

return limitOverrides;
Expand Down
74 changes: 74 additions & 0 deletions tests/e2e/yamcs/load.e2e.spec.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
/*****************************************************************************
* Open MCT, Copyright (c) 2014-2022, United States Government
* as represented by the Administrator of the National Aeronautics and Space
* Administration. All rights reserved.
*
* Open MCT is licensed under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
* http://www.apache.org/licenses/LICENSE-2.0.
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
* License for the specific language governing permissions and limitations
* under the License.
*
* Open MCT includes source code licensed under additional open source
* licenses. See the Open Source Licenses file (LICENSES.md) included with
* this source code distribution or the Licensing information page available
* at runtime from the About dialog for additional information.
*****************************************************************************/

/*
Open MCT load Specific Tests
*/

import { pluginFixtures } from 'openmct-e2e';
const { test, expect } = pluginFixtures;
const YAMCS_URL = 'http://localhost:8090/';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ozyx we need to turn this into a custom variable in the base quickstart fixtures


test.describe("Tests to ensure that open mct loads correctly @yamcs", () => {
test.beforeEach(async ({ page }) => {
await clearCustomAlgorithm(page);
});

test.afterEach(async ({ page }) => {
await clearCustomAlgorithm(page);
});

test('Can load correctly when mdb algorithms are changed at runtime', async ({ page }) => {
// Go to baseURL
await page.goto("./", {waitUntil: "networkidle"});
await expect(page.getByLabel('Navigate to myproject folder')).toBeVisible();

await updateCustomAlgorithm(page);

await page.reload({waitUntil: "networkidle"});

await expect(page.getByLabel('Navigate to myproject folder')).toBeVisible();
});
});

async function clearCustomAlgorithm(page) {
// clear the custom algorithm for the copySunsensor using the yamcs API
const runTimeCustomAlgorithmResetResponse = await page.request.patch(`${YAMCS_URL}api/mdb/myproject/realtime/algorithms/myproject/copySunsensor`, {
data: {
"action": "RESET"
}
});
await expect(runTimeCustomAlgorithmResetResponse).toBeOK();
}

async function updateCustomAlgorithm(page) {
// Change the custom algorithm for the copySunsensor using the yamcs API
const runTimeCustomAlgorithmChangeResponse = await page.request.patch(`${YAMCS_URL}api/mdb/myproject/realtime/algorithms/myproject/copySunsensor`, {
data: {
"action": "SET",
"algorithm": {
"text": "\n\t\t\t\t\tout0.setFloatValue(in.getEngValue().getFloatValue()); \n\t\t\t\t"
}
}
});
await expect(runTimeCustomAlgorithmChangeResponse).toBeOK();
}
Loading