Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add minimal performance test to detect telemetry eviction handover #425

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Add minimal performance test to detect telemetry eviction handover #425

wants to merge 19 commits into from

Conversation

scottbell
Copy link
Collaborator

@scottbell scottbell commented Feb 6, 2024 •
edited by ozyx
Loading

Closes #7312

Describe your changes:

Add telemetry eviction tests by way of FinalizationRegistry

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@scottbell scottbell linked an issue Feb 6, 2024 that may be closed by this pull request
[Performance] Add minimal performance test to detect telemetry eviction nasa/openmct#7312
Open
@scottbell scottbell requested review from ozyx and akhenry February 6, 2024 08:19
@scottbell
Copy link
Collaborator Author

scottbell commented Feb 6, 2024 •
edited
Loading

Note this is not a PR meant to go into review, but a handoff of the telemetry eviction testing ticket to @ozyx. There are some notes here on the current status of this branch. There are two other branches associated with this ticket using the aborted Memlab approach; these can be deleted at your discretion.

@scottbell scottbell changed the title 7312 performance add minimal performance test to detect telemetry eviction handover Add minimal performance test to detect telemetry eviction handover Feb 6, 2024
@scottbell scottbell mentioned this pull request Feb 16, 2024
Closed
@scottbell scottbell marked this pull request as ready for review February 16, 2024 11:17
@scottbell scottbell mentioned this pull request Feb 16, 2024
Open
@ozyx ozyx added this to the Target:4.0.0 milestone Feb 26, 2024
@ozyx ozyx added the type:maintenance chore, tests, build, ci label Feb 26, 2024
@akhenry akhenry requested a review from unlikelyzero June 7, 2024 18:19
@ozyx ozyx force-pushed the 7312-performance-add-minimal-performance-test-to-detect-telemetry-eviction-handover branch from 4271955 to 8064b0d Compare September 10, 2024 19:48
@davetsay
Copy link
Collaborator

@akhenry , i believe this is ready for final review

akhenry
akhenry requested changes Sep 24, 2024
View reviewed changes
package.json
"start:coverage": "npx webpack serve --config ./.webpack/webpack.coverage.mjs",
"prepare": "npm run build:dist",
"test:getopensource": "sh ./tests/git-opensource-tests.sh",
"posttest:getopensource": "npm install",
"test:e2e:smoke": "npm test --workspace tests/e2e/opensource -- --config=../playwright-quickstart.config.js --project=chromium quickstartSmoke",
"test:e2e:quickstart": "npm test --workspace tests/e2e/opensource -- --config=../playwright-quickstart.config.js --project=chromium tests/e2e/yamcs/",
"test:e2e:quickstart:local": "npm test --workspace tests/e2e/opensource -- --config=../playwright-quickstart.config.js --project=local-chrome tests/e2e/yamcs/",
"test:perf:memory": "npm test --workspace tests/e2e/opensource -- --config=../playwright-performance-prod.config.js --project=chrome-memory",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When is test:perf:memory going to run though? It needs to be regularly triggered automatically to catch regressions.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be run with PRs. Let's also make sure navigation memory leak tests are also re-enabled.

.webpack/webpack.common.mjs
proxy: [
{
context: ["/yamcs-proxy/"],
target: "http://0.0.0.0:8090/",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have some mercy for those of us who are targeted by enterprise port scanners, please.

akhenry
akhenry requested changes Sep 24, 2024
View reviewed changes
package.json
"start:coverage": "npx webpack serve --config ./.webpack/webpack.coverage.mjs",
"prepare": "npm run build:dist",
"test:getopensource": "sh ./tests/git-opensource-tests.sh",
"posttest:getopensource": "npm install",
"test:e2e:smoke": "npm test --workspace tests/e2e/opensource -- --config=../playwright-quickstart.config.js --project=chromium quickstartSmoke",
"test:e2e:quickstart": "npm test --workspace tests/e2e/opensource -- --config=../playwright-quickstart.config.js --project=chromium tests/e2e/yamcs/",
"test:e2e:quickstart:local": "npm test --workspace tests/e2e/opensource -- --config=../playwright-quickstart.config.js --project=local-chrome tests/e2e/yamcs/",
"test:perf:memory": "npm test --workspace tests/e2e/opensource -- --config=../playwright-performance-prod.config.js --project=chrome-memory",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be run with PRs. Let's also make sure navigation memory leak tests are also re-enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akhenry akhenry akhenry requested changes

@ozyx ozyx Awaiting requested review from ozyx

@unlikelyzero unlikelyzero Awaiting requested review from unlikelyzero

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
type:maintenance chore, tests, build, ci
Projects
None yet
Milestone
Target:4.0.0
Development

Successfully merging this pull request may close these issues.

[Performance] Add minimal performance test to detect telemetry eviction
4 participants
@scottbell @davetsay @akhenry @ozyx