Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fault MGMT] Support trigger and current values other than doubles #379

Merged
merged 6 commits into from
Oct 2, 2023

Conversation

michaelrogers
Copy link
Collaborator

@michaelrogers michaelrogers commented Sep 20, 2023

Closes #380

Describe your changes:

Used the getValue util to extract the value for currentValue and triggerValue instead of being hardcoded to doubleValue.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@michaelrogers michaelrogers changed the title Fault mgmt value type [Fault MGMT] Support trigger and current values other than doubles Sep 20, 2023
Copy link
Collaborator

@jvigliotta jvigliotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me Michael, nice work!

@ozyx ozyx merged commit c352dd1 into master Oct 2, 2023
3 of 8 checks passed
@ozyx ozyx deleted the fault-mgmt-value-type branch October 2, 2023 21:29
@ozyx ozyx added this to the Target:3.1.0 milestone Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fault Management] View does not show values for many parameter types
3 participants