Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for node 0.6.x #39

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Update for node 0.6.x #39

wants to merge 6 commits into from

Conversation

caolan
Copy link
Contributor

@caolan caolan commented Nov 21, 2011

require.paths has been removed in node 0.6.x, I've commented out the unshift call, but I'm not sure what purpose that line was serving. If the unshift call is essential you may need to find a way to modify the NODE_PATH and spawn a new process instead...

@Baggz
Copy link

Baggz commented Nov 29, 2011

+1

4 similar comments
@kmiyashiro
Copy link

+1

@bermi
Copy link

bermi commented Dec 17, 2011

+1

@djcas9
Copy link

djcas9 commented Dec 20, 2011

+1

@dinedal
Copy link

dinedal commented Dec 23, 2011

+1

@kmiyashiro
Copy link

You guys do know that this project is probably dead so someone should maintain a fork instead?

@analytically
Copy link

+1

@fauzias
Copy link

fauzias commented Jan 6, 2012

It's a great nice awesome project, why it shall be dead? anyone can pinpoint any maintaned fork?

@funston
Copy link

funston commented Feb 1, 2012

With require.paths commented out, seeing this error:

node.js:201
throw e; // process.nextTick error, or 'error' event on first tick
^
TypeError: Cannot call method 'runInNewContext' of undefined
at Object.loadSource (/Users/rich/dev/node_modules/dust/lib/server.js:13:19)

@g13n
Copy link

g13n commented Feb 27, 2012

Apart from commenting out/removing the require.unshift line, the following change is needed:

-Script = process.binding('evals').Script;
+Script = require("vm");

@Filirom1
Copy link

This issue is 5 months old. Is this project dead ?

@kmiyashiro
Copy link

@kethinov
Copy link

kethinov commented May 1, 2012

Is LinkedIn's fork basically the canonical version of dust.js now that the original can't run on current node?

@g13n
Copy link

g13n commented May 1, 2012

Yes it can't. There's an API change after 0.4 that breaks the original version. Also the original is no longer being maintained, you should be using the LinkedIn version which is in active development.

@fijiaaron
Copy link

can you update the npm script to pull dust.js from linkedin if that is official now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.