Add route table association for public subnet B #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…50% chance of not working
…avoid getting a ticket from security
|
@rizvir Thank you for this! I'm happy to accept ec7b176 at this stage, but not e248318 on the basis that (a) the audience for the impact there is limited to a subset of the total audience for this session, and (b) the commit assumes that you're running in a provided account. Let me know if you're happy to re-base this to just include ec7b176, else I'm happy to cherry-pick it to a new branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise stack has 50% chance of not working; because half the time, the instance would be launched in a subnet where it has no internet access (and thus would fail the bootstrap).