Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security of API Service of AJK Town #83

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

mlajkim
Copy link
Contributor

@mlajkim mlajkim commented Mar 2, 2024

Background

Write the basic security standard.

  • Controller must return response with domain.toRes(atd) or domain.toSharedRes()
    • toRes must require atd
    • toSharedRes() does not require atd
  • Service should never ask for atd
  • Service should only return domain or nothing (undefined)
  • Every domain must have the following interfaces
    • IDomainNameShared
      • Even if it is the same as IDomainName it must be specified.
    • IDomainName

TODOs

  • TODO: Write your TODOs.
  • TODO: If your issue has TODOs, please copy appropriate ones here.

Checklist (Developers)

  • Draft is set for this PR
  • Title is checked
  • Background is filled
  • TODOs are filled
  • Assignee is set
  • Labels are set
  • Project is created & linked, if multiple PRs are associated to this PR
  • development is linked if related issue exists
  • yarn inspect is run
  • TODOs are handled and checked
  • Final Operation Check is done
  • Make this PR as an open PR

Checklist (Reviewers)

  • Check if there are any other missing TODOs that are not yet listed
  • Review Code
  • Every item on the checklist has been addressed accordingly
  • If development is associated to this PR, you must check if every TODOs are handled

@mlajkim mlajkim self-assigned this Mar 2, 2024
@mlajkim mlajkim added the documentation Improvements or additions to documentation label Mar 2, 2024
@mlajkim mlajkim marked this pull request as draft March 2, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant