Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wordcard Share Feature Beta Phase 1: Smallest implementation Possible #65

Merged
merged 39 commits into from
Jan 20, 2024
Merged

Wordcard Share Feature Beta Phase 1: Smallest implementation Possible #65

merged 39 commits into from
Jan 20, 2024

Conversation

mlajkim
Copy link
Contributor

@mlajkim mlajkim commented Oct 9, 2023 •
edited
Loading

Background

ajktown/wordnote#109

TODOs

  • Temp: Fix the bug for unable to share
  • Implement an API that has a shareResource based on the designed documentation
    • Make sure to come up with good name that will be future used by many other resources.
  • Write a standard dto and its method, so that it can be used anywhere
  • Implement POST shared-resource (API)
  • Implement GET shared-resource (API)

Checklist (Developers)

  • Related PRs is correctly modified, if it is not None
  • One of the followings is handled
    • At least one or more issue are linked to this PR under development
    • The issue template is directly copied above the Related PRs
    • One of the related PRs is linked to the issue under development
  • Assignee is set
  • Labels are set
  • Title is checked
  • yarn inspect is run
  • Operation Check is done
  • TODOs of associated issue (or TODOs here, if present) are handled and checked

Checklist (Reviewers)

  • Check if there are any other missing TODOs that are not yet listed
  • Every item on the checklist has been addressed accordingly

@mlajkim mlajkim self-assigned this Oct 9, 2023
@mlajkim mlajkim added the enhancement New feature or request label Oct 9, 2023
mlajkim added a commit to ajktown/.github that referenced this pull request Oct 9, 2023
@mlajkim
feat: pull_request_template.md with copy issue
4f080f0 
Allows copying link with issue, instead of directly making it to `Development`, so that you do not have to have the background copied.

Example: ajktown/api#65
This was referenced Oct 9, 2023
Merged
Merged
@mlajkim mlajkim force-pushed the share-word-card-feature branch from 7a84097 to c70b5e0 Compare October 11, 2023 23:29
@mlajkim mlajkim force-pushed the share-word-card-feature branch from c70b5e0 to 8304060 Compare October 31, 2023 22:41
@mlajkim mlajkim force-pushed the share-word-card-feature branch from e567f54 to 7c96941 Compare December 5, 2023 22:58
@mlajkim mlajkim marked this pull request as draft December 21, 2023 22:55
@mlajkim mlajkim changed the title Share Word Card Wordcard Share Feature Dec 23, 2023
@mlajkim mlajkim force-pushed the share-word-card-feature branch from 27966ea to 1711015 Compare January 3, 2024 09:39
@mlajkim mlajkim changed the title Wordcard Share Feature Wordcard Share Feature Beta Phase 1: Smallest implementation Possible Jan 20, 2024
@mlajkim mlajkim marked this pull request as ready for review January 20, 2024 03:02
mlajkim
mlajkim commented Jan 20, 2024
View reviewed changes
Copy link
Contributor Author

@mlajkim mlajkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@mlajkim mlajkim merged commit ff08589 into main Jan 20, 2024
@mlajkim mlajkim deleted the share-word-card-feature branch January 20, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mlajkim mlajkim

Labels
enhancement New feature or request
Projects
[WordnoteGPT] Share Word Card
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mlajkim