Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: PATCH /api/v1/rituals/default returns the GetRitualsResDTO instead #149

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

mlajkim
Copy link
Contributor

@mlajkim mlajkim commented Nov 25, 2024

Background

PATCH /api/v1/rituals/default now return the same format as the GET /api/v1/rituals

Checklist Before PR Review

  • The following has been handled:
    • Draft is set for this PR
    • Title is checked
    • Background is filled
    • Assignee is set
    • Labels are set
    • development is linked if related issue exists

Checklist (Right Before PR Review Request)

  • The following has been handled:
    • Final Operation Check is done
    • Mobile View Operation Check is done
    • Make this PR as an open PR

Checklist (Reviewers)

  • Check if there are any other missing TODOs that are not yet listed
  • Review Code
  • Every item on the checklist has been addressed accordingly
  • If development is associated to this PR, you must check if every TODOs are handled

@mlajkim mlajkim added enhancement New feature or request deprecation Deprecate endpoints etc labels Nov 25, 2024
@mlajkim mlajkim self-assigned this Nov 25, 2024
@mlajkim mlajkim marked this pull request as draft November 25, 2024 21:48
@mlajkim mlajkim removed the deprecation Deprecate endpoints etc label Nov 26, 2024
Copy link
Contributor Author

@mlajkim mlajkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mlajkim mlajkim marked this pull request as ready for review November 26, 2024 22:51
@mlajkim mlajkim merged commit 825354e into main Nov 28, 2024
1 check passed
@mlajkim mlajkim deleted the refactor/ritual-service-and-its-controller branch November 28, 2024 20:00
@mlajkim mlajkim changed the title refactor: for reusability Feat: PATCH /api/v1/rituals/default returns the GetRitualsResDTO instead Dec 7, 2024
mlajkim added a commit to ajktown/ConsistencyGPT that referenced this pull request Dec 8, 2024
# Background
We need to modify the FE to handle the returned data accordingly as API
now returns `GetRitualsResDTO` instead:

![image](https://github.com/user-attachments/assets/ce0aab96-2ff8-4ca9-8134-359fac7dcaf9)
ajktown/api#149

Additionally, there is a bug where the patch rituals sends `isArchived:
true`, `isArchived: true`, which should be `isArchived: true`, as you do
not want to get archived action groups in setting.

## What's done
- `isArchived: true` => `isArchived: false`
- Correct the type for the expected return response

## Checklist Before PR Review
- [x] The following has been handled:
  -  `Draft` is set for this PR
  - `Title` is checked
  - `Background` is filled
  - `Assignee` is set
  - `Labels` are set
  - `development` is linked if related issue exists

## Checklist (Right Before PR Review Request)
- [x] The following has been handled:
  - Final Operation Check is done
  - Mobile View Operation Check is done
  - Make this PR as an open PR

## Checklist (Reviewers)
- [x] Check if there are any other missing TODOs that are not yet listed
- [x] Review Code
- [x] Every item on the checklist has been addressed accordingly
- [x] If `development` is associated to this PR, you must check if every
TODOs are handled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant