Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: private readonly for non-assigned methods/props for class #148

Merged
merged 1 commit into from
Nov 23, 2024
Merged

refactor: private readonly for non-assigned methods/props for class #148

merged 1 commit into from
Nov 23, 2024

Conversation

mlajkim
Copy link
Contributor

@mlajkim mlajkim commented Nov 20, 2024 •
edited
Loading

Background

TID:
image

Checklist Before PR Review

  • The following has been handled:
    • Draft is set for this PR
    • Title is checked
    • Background is filled
    • Assignee is set
    • Labels are set
    • development is linked if related issue exists

Checklist (Right Before PR Review Request)

  • The following has been handled:
    • Final Operation Check is done
    • Mobile View Operation Check is done
    • Make this PR as an open PR

Checklist (Reviewers)

  • Check if there are any other missing TODOs that are not yet listed
  • Review Code
  • Every item on the checklist has been addressed accordingly
  • If development is associated to this PR, you must check if every TODOs are handled

@mlajkim mlajkim self-assigned this Nov 20, 2024
@mlajkim mlajkim marked this pull request as draft November 20, 2024 00:02
mlajkim
mlajkim commented Nov 20, 2024
View reviewed changes
Copy link
Contributor Author

@mlajkim mlajkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@mlajkim mlajkim marked this pull request as ready for review November 20, 2024 23:17
@mlajkim mlajkim merged commit 0758bb7 into main Nov 23, 2024
1 check passed
@mlajkim mlajkim deleted the refactor/readonly-for-non-assigned-class-data branch November 23, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mlajkim mlajkim

Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mlajkim