Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Done! with theme color #81

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Feat: Done! with theme color #81

wants to merge 1 commit into from
+18 −1

Conversation

mlajkim
Copy link
Contributor

@mlajkim mlajkim commented Dec 20, 2024 •
edited
Loading

Background

image
appTheme is not applied for the button Done!

What's done

appTheme is applied

What are the related PRs?

  • N/A

Checklist Before PR Review

  • The following has been handled:
    • Draft is set for this PR
    • Title is checked
    • Background is filled
    • Assignee is set
    • Labels are set
    • Development is linked if related issue exists

Checklist (Right Before PR Review Request)

  • The following has been handled:
    • Final Operation Check is done
    • Mobile View Operation Check is done
    • Make this PR as an open PR
    • What's done is filled & matches to the actual changes

Checklist (Reviewers)

  • Review if the following has been handled:
    • Review Code
    • Checklist Before PR Review is correctly handled
    • Checklist (Right Before PR Review Request) is correctly handled
    • Check if there are any other missing TODOs (Checklists) that are not yet listed
    • Check if issue under Development is fully handled if exists

@mlajkim mlajkim added the enhancement New feature or request label Dec 20, 2024
@mlajkim mlajkim self-assigned this Dec 20, 2024
@mlajkim mlajkim linked an issue Dec 20, 2024 that may be closed by this pull request
Feat: Done Button with Theme! #79
Open
@mlajkim mlajkim force-pushed the feat/done-button-color branch from 9df3743 to d1f4660 Compare December 22, 2024 23:49
mlajkim
mlajkim commented Dec 22, 2024
View reviewed changes
Copy link
Contributor Author

@mlajkim mlajkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mlajkim mlajkim

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: Done Button with Theme!
1 participant
@mlajkim