Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add password warning and password suggestion UI options #6

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add password warning and password suggestion UI options #6

wants to merge 6 commits into from

Conversation

brennan-nc
Copy link

I've done some work on this project in order to present warnings and suggestions to users (as showing password strength itself is a little too non-user friendly for non-technical users, in our opinion). We've forked the repo and are using the fork in our project. If you want any of these changes downstream, here they are.

While I haven't done a ton of backwards compatibility testing. I believe this release to be non-API breaking and that it should be backwards compatible.

Here's a brief change log:

  • You can now display the password warnings and suggestions returned by zxcvbn.
  • The password strength meter now supports jQuery UI as an alternative to Bootstrap.
  • The widget now allows you to validate by password length (min and max).
  • The project is now tested and working in IE8. Some polyfills were added for this.
  • Debounce is now used on the keyup event to have it trigger less frequently.
  • The password strength and confirmation widgets now respect PasswordInput's render_value.
  • Git ignored PyCharm's idea files directory.
  • A javascript/jQuery event, attached to the HTML document, is fired, indicating whether the entered password meets a min score.

If you have any questions or comments, let me know.

brennan-nc and others added 6 commits March 3, 2016 14:42
You can now display the password warnings and suggestions returned by zxcvbn.
The password strength meter now supports jQuery UI as an alternative to Bootstrap.
The widget now allows you to validate by password length (min and max).
The project is now tested and working in IE8. Some polyfills were added for this.
Debounce is now used on the keyup event to have it trigger less frequently.
The password strength and confirmation widgets now respect PasswordInput's render_value.
Git ignored PyCharm's idea files directory.
Made bootstrap the default progress bar ui style.
Added display options, including showing warnings and suggestions.
@aj-may
Copy link
Owner

aj-may commented Mar 31, 2016

Thanks for the PR. This would be easier for me to test and integrate if this was broken into smaller PRs. Would you be able to break this out into 1 feature per PR?

@brennan-nc
Copy link
Author

I'll see what I can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants