Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add(valkey): metrics in prometheus #578

Merged
merged 3 commits into from
Dec 2, 2024
Merged

add(valkey): metrics in prometheus #578

merged 3 commits into from
Dec 2, 2024

Conversation

wojcik-dorota
Copy link
Contributor

@wojcik-dorota wojcik-dorota commented Nov 26, 2024 •
edited
Loading

https://aiven.atlassian.net/browse/DDB-1373

Checklist

  • The first paragraph of the page is on one line.
  • The other lines have a line break at 90 characters.
  • I checked the output.
  • I applied the style guide.
  • My links start with /docs/.

@wojcik-dorota wojcik-dorota requested a review from a team as a code owner November 26, 2024 11:36
@wojcik-dorota wojcik-dorota self-assigned this Nov 26, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Nov 26, 2024 •
edited
Loading

Deploying aiven-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 03112a3
Status: ✅  Deploy successful!
Preview URL: https://b508f950.aiven-docs.pages.dev
Branch Preview URL: https://dorota-add-valkey-promotheus.aiven-docs.pages.dev

View logs

@wojcik-dorota wojcik-dorota marked this pull request as draft November 26, 2024 12:11
@wojcik-dorota wojcik-dorota force-pushed the dorota-add-valkey-promotheus-metrics branch from 7f68485 to 23d96b7 Compare November 26, 2024 12:13
@wojcik-dorota wojcik-dorota force-pushed the dorota-add-valkey-promotheus-metrics branch from d631fab to e640c3e Compare November 29, 2024 14:02
@wojcik-dorota wojcik-dorota marked this pull request as ready for review November 29, 2024 14:03
bogdanp05
bogdanp05 approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@bogdanp05 bogdanp05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wojcik-dorota wojcik-dorota added the review/TW A TW must review the PR. Comes after review/SME. label Nov 29, 2024
staceysalamon-aiven
staceysalamon-aiven approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@staceysalamon-aiven staceysalamon-aiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wojcik-dorota wojcik-dorota merged commit 897b8de into main Dec 2, 2024
4 checks passed
@wojcik-dorota wojcik-dorota deleted the dorota-add-valkey-promotheus-metrics branch December 2, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staceysalamon-aiven staceysalamon-aiven staceysalamon-aiven approved these changes

@bogdanp05 bogdanp05 bogdanp05 approved these changes

Assignees

@wojcik-dorota wojcik-dorota

Labels
ic-balance-existing ic-value-customer review/TW A TW must review the PR. Comes after review/SME. service/valkey
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wojcik-dorota @bogdanp05 @staceysalamon-aiven