Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: add Valkey to Dragonfly migration documentation #551

Merged
merged 7 commits into from
Nov 8, 2024

Conversation

harshini-rangaswamy
Copy link
Contributor

@harshini-rangaswamy harshini-rangaswamy commented Nov 7, 2024

Describe your changes

Add Valkey to migration documentation and update migration steps for clarity.

MA-3062

Checklist

  • The first paragraph of the page is on one line.
  • The other lines have a line break at 90 characters.
  • I checked the output.
  • I applied the style guide.
  • My links start with /docs/.

Copy link

cloudflare-workers-and-pages bot commented Nov 7, 2024

Deploying aiven-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 11ca4a9
Status: ✅  Deploy successful!
Preview URL: https://f1635811.aiven-docs.pages.dev
Branch Preview URL: https://harshini-valkey-df-migration.aiven-docs.pages.dev

View logs

@harshini-rangaswamy harshini-rangaswamy self-assigned this Nov 7, 2024
@harshini-rangaswamy harshini-rangaswamy added the review/SME An SME must review the PR. label Nov 7, 2024
Copy link
Contributor

@bogdanp05 bogdanp05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically lgtm
A couple of comments about DF GA

static/includes/dragonfly-limitations.md Outdated Show resolved Hide resolved
static/includes/dragonfly-limitations.md Outdated Show resolved Hide resolved
@harshini-rangaswamy harshini-rangaswamy marked this pull request as ready for review November 7, 2024 16:06
@harshini-rangaswamy harshini-rangaswamy requested a review from a team as a code owner November 7, 2024 16:06
@harshini-rangaswamy harshini-rangaswamy added review/TW A TW must review the PR. Comes after review/SME. and removed review/SME An SME must review the PR. labels Nov 8, 2024
@harshini-rangaswamy harshini-rangaswamy force-pushed the harshini-valkey-df-migration branch from 276e134 to 859a62c Compare November 8, 2024 09:16
Copy link
Contributor

@wojcik-dorota wojcik-dorota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on that ♥️
Most if not all of my comments I submitted for "Migrate Aiven for Caching or Aiven for Valkey™ to Aiven for Dragonfly®" also apply to "Migrate external Redis®* or Valkey databases to Aiven for Dragonfly®". Please apply as needed.

@harshini-rangaswamy harshini-rangaswamy requested review from wojcik-dorota and removed request for nctbao November 8, 2024 13:21
Copy link
Contributor

@wojcik-dorota wojcik-dorota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐️⭐️⭐️

@harshini-rangaswamy harshini-rangaswamy merged commit 0ec474a into main Nov 8, 2024
4 checks passed
@harshini-rangaswamy harshini-rangaswamy deleted the harshini-valkey-df-migration branch November 8, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review/TW A TW must review the PR. Comes after review/SME. service/dragonfly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants