Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: Migration from Caching to Valkey #508

Merged
merged 4 commits into from
Oct 25, 2024
Merged

add: Migration from Caching to Valkey #508

merged 4 commits into from
Oct 25, 2024

Conversation

harshini-rangaswamy
Copy link
Contributor

@harshini-rangaswamy harshini-rangaswamy commented Oct 15, 2024 •
edited
Loading

Describe your changes

Added migration process from Aiven for Caching or Valkey to Aiven for Valkey.

MA-3046

Checklist

  • The first paragraph of the page is on one line.
  • The other lines have a line break at 90 characters.
  • I checked the output.
  • I applied the style guide.
  • My links start with /docs/.

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Oct 15, 2024 •
edited
Loading

Deploying aiven-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: ab1ce2c
Status: ✅  Deploy successful!
Preview URL: https://8aebec66.aiven-docs.pages.dev
Branch Preview URL: https://harshini-migration-to-metric.aiven-docs.pages.dev

View logs

@harshini-rangaswamy harshini-rangaswamy marked this pull request as ready for review October 15, 2024 14:32
@harshini-rangaswamy harshini-rangaswamy requested a review from a team as a code owner October 15, 2024 14:32
@harshini-rangaswamy harshini-rangaswamy self-assigned this Oct 15, 2024
@harshini-rangaswamy harshini-rangaswamy added review/SME An SME must review the PR. service/valkey labels Oct 15, 2024
@hoang-vo hoang-vo requested a review from bogdanp05 October 21, 2024 09:38
bogdanp05
bogdanp05 requested changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@bogdanp05 bogdanp05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good apart from the typo

docs/products/valkey/howto/migrate-caching-valkey-to-aiven-for-valkey.md Outdated Show resolved Hide resolved
bogdanp05
bogdanp05 approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@bogdanp05 bogdanp05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@harshini-rangaswamy harshini-rangaswamy removed the review/SME An SME must review the PR. label Oct 25, 2024
wojcik-dorota
wojcik-dorota approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@wojcik-dorota wojcik-dorota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few tiny suggestions

docs/products/valkey/howto/migrate-caching-valkey-to-aiven-for-valkey.md Outdated Show resolved Hide resolved
docs/products/valkey/howto/migrate-caching-valkey-to-aiven-for-valkey.md Outdated Show resolved Hide resolved
docs/products/valkey/howto/migrate-caching-valkey-to-aiven-for-valkey.md Outdated Show resolved Hide resolved
docs/products/valkey/howto/migrate-caching-valkey-to-aiven-for-valkey.md Show resolved Hide resolved
docs/products/valkey/howto/migrate-caching-valkey-to-aiven-for-valkey.md Outdated Show resolved Hide resolved
@harshini-rangaswamy harshini-rangaswamy merged commit 2a751fa into main Oct 25, 2024
4 checks passed
@harshini-rangaswamy harshini-rangaswamy deleted the harshini-migration-to-metrics branch October 25, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojcik-dorota wojcik-dorota wojcik-dorota approved these changes

@bogdanp05 bogdanp05 bogdanp05 approved these changes

@hoang-vo hoang-vo Awaiting requested review from hoang-vo

Assignees

@harshini-rangaswamy harshini-rangaswamy

Labels
service/valkey
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harshini-rangaswamy @bogdanp05 @wojcik-dorota