Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: NATS polling subscriber #912

Merged
merged 20 commits into from
Nov 9, 2023
Merged

feat: NATS polling subscriber #912

merged 20 commits into from
Nov 9, 2023

Conversation

sheldygg
Copy link
Contributor

@sheldygg sheldygg commented Nov 3, 2023 •
edited by Lancetnik
Loading

Description

Please include a summary of the change and specify which issue is being addressed. Additionally, provide relevant motivation and context.

Close #781

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-anaylysis.sh
  • I have included code examples to illustrate the modifications

@sheldygg sheldygg changed the title draft for pull_subscribe draft for pull_subscribe, object and kv storage Nov 4, 2023
@Lancetnik Lancetnik self-assigned this Nov 5, 2023
@Lancetnik Lancetnik added the enhancement New feature or request label Nov 5, 2023
@Lancetnik Lancetnik changed the title draft for pull_subscribe, object and kv storage feat: NATS polling and watch subscribers Nov 5, 2023
@Lancetnik Lancetnik changed the title feat: NATS polling and watch subscribers feat: NATS polling subscriber Nov 6, 2023
@Lancetnik Lancetnik requested a review from kumaranvpl November 7, 2023 19:02
@Lancetnik Lancetnik marked this pull request as ready for review November 7, 2023 19:02
@Lancetnik
Copy link
Member

Lancetnik commented Nov 7, 2023 •
edited
Loading

@kumaranvpl can u please check the NATS Pull documentation page and then release this one? In the 0.2.12 release we can just set link to this documentation page, I think

@kumaranvpl kumaranvpl self-assigned this Nov 8, 2023
Lancetnik
Lancetnik previously approved these changes Nov 8, 2023
View reviewed changes
kumaranvpl
kumaranvpl approved these changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@kumaranvpl kumaranvpl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and updated the docs. @Lancetnik

@kumaranvpl kumaranvpl enabled auto-merge November 9, 2023 12:55
@kumaranvpl kumaranvpl added this pull request to the merge queue Nov 9, 2023
Merged via the queue into airtai:main with commit 427abf1 Nov 9, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaranvpl kumaranvpl kumaranvpl approved these changes

@Lancetnik Lancetnik Lancetnik left review comments

Assignees

@kumaranvpl kumaranvpl

@Lancetnik Lancetnik

Labels
enhancement New feature or request
Projects
FastStream
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: NATS polling subscriber
4 participants
@sheldygg @Lancetnik @kumaranvpl @davorrunje