Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overwrite message schema #2007

Merged
merged 3 commits into from
Dec 25, 2024
Merged

Overwrite message schema #2007

merged 3 commits into from
Dec 25, 2024

Conversation

ApostolFet
Copy link

Description

Using an overwritten message scheme and warning the user in this case
Fixes #1625

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • My changes DO generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-analysis.sh

@Lancetnik
Copy link
Member

@KrySeyt can you review this one, please?

@KrySeyt
Copy link
Contributor

KrySeyt commented Dec 25, 2024

В остальном LGTM

KrySeyt
KrySeyt suggested changes Dec 25, 2024
View reviewed changes
tests/asyncapi/base/v2_6_0/arguments.py Outdated

payload = schema["components"]["schemas"]

for key, v in payload.items():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Зачем здесь цикл? У нас же должен быть только один пейлоад

tests/asyncapi/base/v3_0_0/arguments.py Outdated

payload = schema["components"]["schemas"]

for key, v in payload.items():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тут тоже

@Lancetnik Lancetnik merged commit 8737347 into airtai:0.6.0 Dec 25, 2024
25 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrySeyt KrySeyt KrySeyt requested changes

@Lancetnik Lancetnik Lancetnik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ApostolFet @Lancetnik @KrySeyt