Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Non-blocking polling for confluent kafka driver. #2001

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

DABND19
Copy link

@DABND19 DABND19 commented Dec 21, 2024

Description

This request pool is strongly inspired by an issue from the confluent-kafka-python project: confluentinc/confluent-kafka-python#612. I'm trying to stop using the call_or_wait function for the main message consuming flow.

Fixes #1904

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-analysis.sh
  • I have included code examples to illustrate the modifications

@DABND19 DABND19 marked this pull request as draft December 21, 2024 14:16
@DABND19 DABND19 force-pushed the feat/non-blocking-polling-for-confluent-kafka-driver branch 2 times, most recently from e1eb153 to 247c67e Compare December 21, 2024 19:49
@DABND19 DABND19 force-pushed the feat/non-blocking-polling-for-confluent-kafka-driver branch from 247c67e to 1529c8a Compare December 21, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Confluent message consuming refactoring
1 participant