Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference of "faststream.access" from docs #1995

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

rishabhc32
Copy link
Contributor

Description

faststream.access is not the correct way of configuring faststream's loggers. So remove their reference from docs.

Also the import from faststream.log import access_logger is not valid.

Fixes #1994

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-analysis.sh
  • I have included code examples to illustrate the modifications

@Lancetnik
Copy link
Member

LGTM, thank you

@Lancetnik Lancetnik enabled auto-merge December 16, 2024 20:25
@Lancetnik Lancetnik added this pull request to the merge queue Dec 17, 2024
Merged via the queue into airtai:main with commit 2ba3eed Dec 17, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Remove ambiguity from faststream logging docs
2 participants