fix: RabbitBroker's ping is more objective #1933
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have a situation where RabbitMQ is up, a service is up with a successful connection to RabbitMQ, I stop it, a reconnection occurs to it every n seconds.
in fact there is no connection, my /readiness handle returns 204, although the service is not readiness.
the ping method checks the connection's
is_closed
flag, although this is not entirely correct, because it will beTrue
only whenclose
/__del__
/__aexit__
is called on the connectionchecking the
connected
attribute of theconnection
object will be more objective:True
when there is a connection,False
when there is not (there was no connection right away, or a reconnection occurs)Type of change
Checklist
scripts/lint.sh
shows no errors)scripts/test-cov.sh
scripts/static-analysis.sh