Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: HandlerException ingored #1928

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

roma-frolov
Copy link
Contributor

Description

In the current version of FastStream, if I raise AckMessage (or any HandlerException) when processing a message, then the following line will be added to the error metric:

faststream_received_processed_messages_exceptions_total{app_name="faststream",broker="rabbitmq",exception_type="AckMessage",handler="default.queue"} 1.0

It shouldn't be like this, because HandlerExceptions are not user-defined exceptions and should not increase the error metric when they are thrown

Type of change

  • Bug fix (a non-breaking change that resolves an issue)

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-analysis.sh
  • I have included code examples to illustrate the modifications

@Lancetnik Lancetnik enabled auto-merge November 20, 2024 19:49
@Lancetnik Lancetnik added this pull request to the merge queue Nov 20, 2024
Merged via the queue into airtai:main with commit f751238 Nov 20, 2024
32 checks passed
@roma-frolov roma-frolov deleted the prom-ignored-exception branch November 21, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants