Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add kafka concurrent subscriber #1912

Merged
merged 11 commits into from
Nov 22, 2024

Conversation

Flosckow
Copy link
Contributor

Description

Please include a summary of the change and specify which issue is being addressed. Additionally, provide relevant motivation and context.

Fixes # (issue number)

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-analysis.sh
  • I have included code examples to illustrate the modifications

@Flosckow
Copy link
Contributor Author

@Lancetnik, can you check this?

@Flosckow Flosckow marked this pull request as ready for review November 21, 2024 13:37
@Flosckow Flosckow changed the title Feat: stage 1 add typing, and mock class for concurrent subscriber Feat: Add kafka concurrent subscriber Nov 21, 2024
@Lancetnik Lancetnik added this pull request to the merge queue Nov 22, 2024
Merged via the queue into airtai:main with commit 9bc7a05 Nov 22, 2024
32 checks passed
@yann-combarnous
Copy link

@Flosckow, out of curiosity, anything to your best knowledge preventing implementing this feature for Confluent?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants