Add allow_auto_create_topics to make automatic topic creation configurable #1556
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We used to always create topics automatically and provided no way to make it configurable. This PR introduces a new variable called
allow_auto_create_topics
to make automatic topic creation configurable.I have included a warning when
allow_auto_create_topics
is set toFalse
becauseconfluent-kafka-python
backfires/crumbles terribly if it tries to access an non existent topic as mentioned here - confluentinc/confluent-kafka-python#1547.There were few blocking calls in the
__init__
method of Async Confluent Producer and Consumer. I have usedrun_in_executor
to make them non-blocking.Fixes #1486, #1363
Type of change
Please delete options that are not relevant.
Checklist
scripts/lint.sh
shows no errors)scripts/test-cov.sh
scripts/static-analysis.sh