Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (#1544): correct Redis message nack & reject signature #1546

Merged
merged 3 commits into from
Jun 21, 2024
Merged

fix (#1544): correct Redis message nack & reject signature #1546

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f93bb25
fix (#1544): correct Redis message nack & reject signature
Lancetnik Jun 21, 2024
f1a271f
docs: generate API References
Lancetnik Jun 21, 2024
10bf185
chore: trigger CI
Lancetnik Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ pytest -m 'all'
If you don't have a local broker instance running, you can run tests without those dependencies:

```bash
pytest -m 'not rabbit and not kafka and not nats and not redis'
pytest -m 'not rabbit and not kafka and not nats and not redis and not confluent'
```

To run tests based on RabbitMQ, Kafka, or other dependencies, the following dependencies are needed to be started as docker containers:
Expand Down
16 changes: 16 additions & 0 deletions faststream/redis/message.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,22 @@ async def ack(
await redis.xack(channel, group, *ids) # type: ignore[no-untyped-call]
await super().ack()

@override
async def nack(
self,
redis: Optional["Redis[bytes]"] = None,
group: Optional[str] = None,
) -> None:
await super().nack()

@override
async def reject(
self,
redis: Optional["Redis[bytes]"] = None,
group: Optional[str] = None,
) -> None:
await super().reject()


class RedisStreamMessage(_RedisStreamMessageMixin[DefaultStreamMessage]):
pass
Expand Down