-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NatsBroker.new_inbox() #1543
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
7badf7f
docs: update CONTRIBUTING.md
maxalbert 2a89a0f
feat: enable spy_decorator to wrap both async and non-async methods
maxalbert 7bd6151
feat: add NatsBroker.new_inbox()
maxalbert 7b92dd1
chore: linting
maxalbert 3e90aa4
fix: raise error if new_inbox() is called before broker was started
maxalbert 0c2447a
refactor: use assert statement instead of raising an exception
maxalbert 91added
docs: mention 'inbox_prefix' argument in docstring for 'new_inbox()'
maxalbert 30d7dc1
Merge branch 'main' into feat/nats-new-inbox
maxalbert File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
from unittest.mock import patch | ||
|
||
import pytest | ||
from nats.aio.client import Client as NatsClient | ||
|
||
from faststream.nats import NatsBroker | ||
from tests.tools import spy_decorator | ||
|
||
|
||
@pytest.mark.asyncio() | ||
@pytest.mark.nats() | ||
async def test_new_inbox(): | ||
with patch.object( | ||
NatsClient, | ||
"new_inbox", | ||
spy_decorator(NatsClient.new_inbox), | ||
) as m: | ||
broker = NatsBroker(inbox_prefix="_FOO_TEST_INBOX") | ||
await broker.connect() | ||
inbox_name = await broker.new_inbox() | ||
|
||
m.mock.assert_called_once() | ||
assert inbox_name.startswith("_FOO_TEST_INBOX.") |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should add assert here to check, that the broker is already connected (and ignore this asset by noseq)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the hint. I only saw this comment after I added a check which raises a RuntimeError. Please let me know if you'd like me to use a regular assert statement instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, use assert in this case. I prefer to use switchable checks for development.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, done. Out of curiosity, what do you mean by using "switchable checks for development"?