-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve Issue 1386, Add rpc_prefix #1484
Conversation
Statis analysis error, not sure how you guys would like to go about this issue in static analysis.
|
We can no worry about this warning due we doesn't use random for cryptography |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like an idea to add an extra option if nats-py already has the mechanism we can reuse
@Lancetnik with the removal of rpc_prefix, realistically that would mean no new tests are needed, would that be a safe assumption since the inbox update would just fall under regular tests. Also, having a hard time running the tests in github workspaces, maybe we can do a setup guide for others or like a make file what are your thoughts? |
@aKardasz I think, we should update CONTRIBUTING file to allow users to contribute easily About testing - I think we should check Can you please add any test for it and then we can merge the branch? |
We could create devcontainers with the complete setup for testing particular MQ. That would probably be the best solution. |
Let me know if the added test is sufficient. |
Description
Adds nuid from nats broker to generation unique ids.
Adds rpc_prefix, to allow support for nats streams inbox_. functionality via permissions, for consistency added the same rpc_prefix to the redis implementation.
Fixes #1386
Type of change
Please delete options that are not relevant.
Checklist
scripts/lint.sh
shows no errors)scripts/test-cov.sh
scripts/static-analysis.sh