975 use aio pika pool #1401
Merged
975 use aio pika pool #1401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lancetnik
requested changes
Apr 26, 2024
|
Sure, will do! |
Lancetnik
reviewed
May 2, 2024
faststream/rabbit/broker/broker.py
Outdated
| @@ -346,23 +357,34 @@ async def _connect( # type: ignore[override] | |||
| *, | |||
| timeout: "TimeoutType", | |||
| ssl_context: Optional["SSLContext"], | |||
| max_connection_pool_size: int = 1, | |||
| max_channel_pool_size: int = 1, | |||
There was a problem hiding this comment.
Can you plase add these options with Annotated[..., Doc()] declaration to RabbitBroker.__init__ and FastAPI integration router init method too?
There was a problem hiding this comment.
Sorry for the delay, it's done!
Lancetnik
requested changes
May 9, 2024
|
Thank you for the work! I am planning a some new RabbitMQ features soon. So, I'll merge it after #1383 as a first step of RMQ changes |
|
@Lancetnik Now that #1383 is merged, any updates on this one? |
|
We can merge it any moment, but it will be released is a part of big RMQ update. Now I am preparing code-base and collect my forces to start working on this change |
|
I start to work on RMQ changes in (#1510) scope, this branch will be base of it, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use aio-pika pools for handling rabbit connections and channels
Fixes #975
Type of change
Please delete options that are not relevant.
Checklist
scripts/lint.shshows no errors)scripts/test-cov.shscripts/static-anaylysis.sh