-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1129 - Create a publish command for the CLI #1151
Conversation
Having issues running tests locally. They seem to get stuck and the test run never finishes. Opened this draft PR to get eyes on the work and get feedback on whether the changes here fulfill the requirements of adding this feature. |
@MRLab12 do you need help with this? |
Hey @davorrunje , this PR is in Draft because I wanted to check I had the correct logic and if the code changes are doing the intended changes. I haven't looked into the tests yet, will check. If it looks good to be reviewed, I can mark it ready. Would also be helpful if you can recommend next steps for documenting and other checks before having this PR ready to be deployed. |
@MRLab12 can you please give me write access to your repo, I would like to push some changes to your branch |
@davorrunje Sent you invite for access. |
@MRLab12 The tests are failing for Python versions 3.8 and 3.9. Can you please check locally with the following command:
I think your tests are interfering with the rest. Can you please check the way you handle async code and compare it with the |
@davorrunje Thanks for the help with this. It is in fact the tests that I added that are not properly handling the async event loop. Looking into and should have a fix coming up. |
…129-CLI-publish-command # Conflicts: # tests/cli/test_publish.py
@davorrunje Hey I was really busy with interviews and did not have a chance to take a look a this. I was able to find that adding |
@MRLab12 Thanx for the PR, I am merging it now :) |
Description
Users should be able to publish a test message right from the command line. To do this, a
publish
command has been added to the CLImain.py
file.Close #1129
How to Test
To test the new publish functionality introduced in this Pull Request, follow these steps:
Start Your FastStream Application: First, you need to have a running FastStream application. You can start your application with the following command, assuming your FastStream application is defined in a file named
testfaststreamapp.py
:Make sure your FastStream application is set up to subscribe to a channel named
input_channel
and publishes processed messages to another channel (e.g.,output_channel
). Here's a simple example of what yourtestfaststreamapp.py
might contain:Send a Test Message: With your FastStream application running, you can send a test message using the
faststream publish
command. Use the following command to publish a message to theinput_channel
:Type of change
Checklist
scripts/lint.sh
shows no errors)scripts/test-cov.sh
scripts/static-anaylysis.sh