Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for confluent python lib #1042

Merged
merged 72 commits into from
Jan 12, 2024
Merged

Add support for confluent python lib #1042

merged 72 commits into from
Jan 12, 2024

Conversation

kumaranvpl
Copy link
Collaborator

@kumaranvpl kumaranvpl commented Dec 13, 2023

Description

Please include a summary of the change and specify which issue is being addressed. Additionally, provide relevant motivation and context.

Closes #1026

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-anaylysis.sh
  • I have included code examples to illustrate the modifications

@kumaranvpl kumaranvpl marked this pull request as draft December 13, 2023 07:08
@kumaranvpl kumaranvpl marked this pull request as ready for review January 11, 2024 13:58
@Lancetnik
Copy link
Member

Looks great, but I can take a look close only this saturday
Btw, if we want to release it as 0.4.0, we should remove required deprecated notices

@davorrunje davorrunje added this pull request to the merge queue Jan 12, 2024
Merged via the queue into main with commit 5cac95b Jan 12, 2024
56 checks passed
@davorrunje davorrunje deleted the use-confluent branch January 12, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace aiokafka with confluent
4 participants