feat: pretty prometheus tests

airtai · Dec 20, 2024 · 4c26157 · 4c26157
1 parent 2f6abd9
commit 4c26157
Show file tree

Hide file tree

Showing 24 changed files with 393 additions and 302 deletions.
diff --git a/faststream/confluent/response.py b/faststream/confluent/response.py
@@ -109,7 +109,7 @@ def from_cmd(
             if body is None:
                 body = EMPTY
 
-            if isinstance(body, Sequence) and not isinstance(body, str):
+            if isinstance(body, Sequence) and not isinstance(body, (str, bytes)):
                 if body:
                     body, extra_bodies = body[0], body[1:]
                 else:

diff --git a/faststream/kafka/response.py b/faststream/kafka/response.py
@@ -101,7 +101,7 @@ def from_cmd(
             if body is None:
                 body = EMPTY
 
-            if isinstance(body, Sequence) and not isinstance(body, str):
+            if isinstance(body, Sequence) and not isinstance(body, (str, bytes)):
                 if body:
                     body, extra_bodies = body[0], body[1:]
                 else:

diff --git a/faststream/redis/response.py b/faststream/redis/response.py
@@ -130,7 +130,7 @@ def from_cmd(
             if body is None:
                 body = EMPTY
 
-            if isinstance(body, Sequence) and not isinstance(body, str):
+            if isinstance(body, Sequence) and not isinstance(body, (str, bytes)):
                 if body:
                     body, extra_bodies = body[0], body[1:]
                 else:

diff --git a/faststream/response/response.py b/faststream/response/response.py
@@ -52,7 +52,7 @@ def __init__(
 
     @property
     def batch_bodies(self) -> tuple["Any", ...]:
-        if self.body:
+        if self.body or isinstance(self.body, (str, bytes)):
             return (self.body,)
         return ()
 

diff --git a/tests/brokers/confluent/test_publish_command.py b/tests/brokers/confluent/test_publish_command.py
@@ -34,6 +34,8 @@ def test_kafka_response_class():
         pytest.param(None, (), id="None Response"),
         pytest.param((), (), id="Empty Sequence"),
         pytest.param("123", ("123",), id="String Response"),
+        pytest.param("", ("",), id="Empty String Response"),
+        pytest.param(b"", (b"",), id="Empty Bytes Response"),
         pytest.param([1, 2, 3], (1, 2, 3), id="Sequence Data"),
         pytest.param([0, 1, 2], (0, 1, 2), id="Sequence Data with False first element"),
     ),

diff --git a/tests/brokers/kafka/test_publish_command.py b/tests/brokers/kafka/test_publish_command.py
@@ -34,6 +34,8 @@ def test_kafka_response_class():
         pytest.param(None, (), id="None Response"),
         pytest.param((), (), id="Empty Sequence"),
         pytest.param("123", ("123",), id="String Response"),
+        pytest.param("", ("",), id="Empty String Response"),
+        pytest.param(b"", (b"",), id="Empty Bytes Response"),
         pytest.param([1, 2, 3], (1, 2, 3), id="Sequence Data"),
         pytest.param([0, 1, 2], (0, 1, 2), id="Sequence Data with False first element"),
     ),

diff --git a/tests/brokers/redis/test_publish_command.py b/tests/brokers/redis/test_publish_command.py
@@ -34,6 +34,8 @@ def test_kafka_response_class() -> None:
         pytest.param(None, (), id="None Response"),
         pytest.param((), (), id="Empty Sequence"),
         pytest.param("123", ("123",), id="String Response"),
+        pytest.param("", ("",), id="Empty String Response"),
+        pytest.param(b"", (b"",), id="Empty Bytes Response"),
         pytest.param([1, 2, 3], (1, 2, 3), id="Sequence Data"),
         pytest.param([0, 1, 2], (0, 1, 2), id="Sequence Data with False first element"),
     ),