playwright coverage WIP2(6)

airtai · Nov 12, 2024 · 198021a · 198021a
1 parent 68c2dd5
commit 198021a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/.github/workflows/test-playwright.yaml b/.github/workflows/test-playwright.yaml
@@ -103,14 +103,11 @@ jobs:
         id: fastagency-start
         run: |
             # Start fastagency and grab its pid
-            # export COVERAGE_PROCESS_START
             nohup gunicorn --workers=1  e2e.llm-sans.main:app >nohup.txt 2>nohup-error.txt &
             # Get the process ID (PID)
             FAST_PID=$!
             echo "Started fastagency with PID: $FAST_PID"
             echo "FAST_PID=$FAST_PID" >> $GITHUB_OUTPUT
-            echo "Sleeping for 5 seconds to let fastagency start up..."
-            sleep 5
         env:
             COVERAGE_PROCESS_START: "e2e/playwright.coverage.cfg"
       - run: echo "obtained FAST_PID" ${{ steps.fastagency-start.outputs.FAST_PID}}

diff --git a/playwright.llm-sans.config.ts b/playwright.llm-sans.config.ts
@@ -3,5 +3,11 @@ import { defineConfig } from "./e2e/playwright.base.config.ts";
 export default defineConfig(
     {
         testDir: './e2e/llm-sans',
-    }
+        webServer: {
+            command: 'fastagency run e2e/llm-sans/main.py',
+            url: 'http://127.0.0.1:32123',
+            //        env: testEnv,
+            reuseExistingServer: true,
+        },
+    },
 )