-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zed2i -> Zed rename #152
Zed2i -> Zed rename #152
Conversation
thanks for making it more generic! I think this is a good way to handle the change, I had the same in mind. maybe one suggestion: keep the Zed2i class in the Zed2i file instead of in the zed file? makes more sense imo. Questions:
|
additional question: do we already want to update all use of the Zed2i in the airo-mono codebase? e.g. https://github.com/airo-ugent/airo-mono/blob/zed_refactor/airo-camera-toolkit/airo_camera_toolkit/cameras/camera_discovery.py |
Good idea, will do
It supports ZED, ZED 2/2i and ZED Mini. For supporting the GMSL cameras we need to add additional resolution profiles: https://www.stereolabs.com/docs/video/camera-controls#resolution-for-gmsl-cameras-zed-xx-mini I could add these if we want.
The Zed mini works out of the box with the old Zed2i class and all manual tests pass*, so I don't think this is needed per se |
No don't think we will use them in the near future. So if it works for all Zed 1 and zed 2 cameras, we're good I think.
ok, great! |
Describe your changes
fix #151
Renamed
Zed2i
toZed
andzed2i.py
tozed.py
, but kept the old names as aliases for backwards compatibility.The
Zed2i
class now inherits fromZed
without making any changes, such that existing code usingZed2i
will still work. A@deprecated
decorator has been added to theZed2i
class.Alternatively, we could not deprecate
Zed2i
, but add a second classZedMini
that also inherits fromZed
. But since the Zed SDK itself is generic over the different camera types, I'm a proponent of a genericZed
class in airo-mono and deprecating the oldZed2i
, as I've done here.Thoughts @tlpss @Victorlouisdg ?
Checklist