-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collision filtering #4
Conversation
From the Drake C++ API documentation (source):
Hence, if we update the collision filter manager of the scene graph after construction of the For our use cases, we will mostly want to use the When use cases arise where we want to do more in simulation or model certain constraints, we will want to add functionality that works with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks great, these are very useful features for airo-drake! Feel free to merge and release a new version of airo-drake.
collision_checker: SceneGraphCollisionChecker, | ||
body_indices_one: List[BodyIndex], | ||
body_indices_two: List[BodyIndex], | ||
*, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this asterisk * an accident?
Adds examples to the collision checking notebook of:
SceneGraphCollisionChecker
(SGCC)In this current version, these methods are incompatible. When filtering with the SGCC, we will still get contacts when using the plant's contact output port. If we use an alternative method of filtering, see here, using the scene graph's collision filter manager, then we get the opposite: the SGCC will report that the configuration is not collision free, but there will be zero contacts reported from the plant's contact output port.
I will investigate further, this link will probably be useful. Most likely, this is due to these two operating on different contexts.