This repository has been archived by the owner on May 18, 2021. It is now read-only.
Allow for pushing configs through the coordinator to S3 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Introduce WritableRepository interface as a method of allowing for a repository to define how to push items instead of just being able to pull them. 2) Create S3Repository that implements WritableRepository and works off stuff existing in an s3 bucket somewhere 3) Introduce CoordinatorConfigProxyResource which is a simple resource that allows for the getting of configs. It will also allow for the setting if the Repository instance implements WritableRepository 4) Some stuff to make it Guice inject, I think...
2) Fix up the keyPrefix and path handling of slashes...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request more as a question of if this is a completely horrible direction and you are morally opposed to it, or if something along these lines is actually acceptable. I believe that setting up a maven repository on the side for the storage of config bundles is too much friction to actually get started, so I'm trying to come up with another option that could be done with much less friction.
The idea was that if I can push configs to the coordinator then the world would be a bit nicer. The big issue is that Repositories are read-only and generate URIs for the actual reading, so it is a little awkward to add "put" methods on the Repository interface (things like HttpRepository cannot really implement it meaningfully). Anyway, these are my changes, let me know if this is a direction I should continue pursuing.