Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate --host, add --external-host #66

Merged
merged 4 commits into from
Jul 31, 2024
Merged

Conversation

colesnodgrass
Copy link
Member

  • fix https://github.com/airbytehq/airbyte-internal-issues/issues/8890
  • deprecate --host flag
  • add --external-host flag
    • if --external-host is specified, use it regardless of --host
    • if --host is specified, output a deprecation warning and
      • if --external-host is specified, use --external-host
      • if --external-host is not specified, use --host

Copy link
Collaborator

@perangel perangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@colesnodgrass colesnodgrass merged commit b67a2f9 into main Jul 31, 2024
2 checks passed
@colesnodgrass colesnodgrass deleted the cole/rename-host branch July 31, 2024 23:15
colesnodgrass added a commit that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants