Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add debug logs for helm #58

Merged
merged 6 commits into from
Jul 23, 2024
Merged

feat: add debug logs for helm #58

merged 6 commits into from
Jul 23, 2024

Conversation

colesnodgrass
Copy link
Member

  • replace the noopWriter with a helmLogger
    • helm generates a lot of logs, which is why it was originally noop'd but there may be some useful information in those logs, which is why they are not output as debug logs

@colesnodgrass colesnodgrass requested review from perangel and a team July 23, 2024 16:30
perangel
perangel approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@perangel perangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small ask to just name the params in the interface definition (for consistency)

internal/cmd/local/helm/helm.go Outdated Show resolved Hide resolved
internal/cmd/local/helm/helm.go Outdated Show resolved Hide resolved
@colesnodgrass colesnodgrass merged commit 59f418e into main Jul 23, 2024
2 checks passed
@colesnodgrass colesnodgrass deleted the cole/helm-logging branch July 23, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perangel perangel perangel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colesnodgrass @perangel