Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: convert telemetry user_id from ulid to uuid #34

Merged
merged 5 commits into from
May 31, 2024
Merged

feat: convert telemetry user_id from ulid to uuid #34

merged 5 commits into from
May 31, 2024

Conversation

colesnodgrass
Copy link
Member

  • fix airbytehq/airbyte-internal-issues#7977
  • convert the telemetry user_id type from ulid to uuid
    • this is backwards compatible as this uses a new *_uuid field in the analytics.yml file
  • update pr title check to be in sync with platform pr title check
  • add a lot of tests to verify user_id transition happens correctly

@colesnodgrass colesnodgrass requested review from a team and perangel May 30, 2024 22:36
@colesnodgrass colesnodgrass merged commit 0070b8c into main May 31, 2024
2 checks passed
@colesnodgrass colesnodgrass deleted the cole/update-ulid-to-uuid branch May 31, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perangel perangel Awaiting requested review from perangel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colesnodgrass @perangel