feat: introduce error codes #126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colesnodgrass
approved these changes
Sep 18, 2024
| @@ -172,3 +174,13 @@ type body struct { | |||
| Timestamp string `json:"timestamp"` | |||
| WriteKey string `json:"writeKey"` | |||
| } | |||
|
|
|||
| func findErrorCode(properties map[string]string, err error) { | |||
| if v, ok := err.(interface{ErrorCode() string}); ok { | |||
There was a problem hiding this comment.
Should we introduce this as a formal interface?
There was a problem hiding this comment.
🤷 this is a pretty standard Go pattern. You want a public interface?
|
I'm actually going to hold off on this for now. I might improve it and come back with a better version later, but also the error cases in the telemetry are working fairly well at this point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce error codes to the telemetry for easier tracking.