Skip to content

Commit

Permalink
feat: increase default cpu/mem limits (#44)
Browse files Browse the repository at this point in the history
  • Loading branch information
colesnodgrass authored Jul 9, 2024
1 parent 51aec41 commit 1319dd5
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
2 changes: 2 additions & 0 deletions internal/cmd/local/local/cmd.go
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,8 @@ func (c *Command) Install(ctx context.Context, opts InstallOpts) error {

airbyteValues := []string{
fmt.Sprintf("global.env_vars.AIRBYTE_INSTALLATION_ID=%s", telUser),
fmt.Sprintf("global.jobs.resources.limits.cpu=3"),
fmt.Sprintf("global.jobs.resources.limits.memory=4Gi"),
}

if opts.dockerAuth() {
Expand Down
10 changes: 8 additions & 2 deletions internal/cmd/local/local/cmd_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ func TestCommand_Install(t *testing.T) {
Timeout: 10 * time.Minute,
ValuesOptions: values.Options{Values: []string{
"global.env_vars.AIRBYTE_INSTALLATION_ID=" + userID.String(),
"global.jobs.resources.limits.cpu=3",
"global.jobs.resources.limits.memory=4Gi",
}},
},
release: release.Release{
Expand Down Expand Up @@ -189,8 +191,12 @@ func TestCommand_Install_ValuesFile(t *testing.T) {
CreateNamespace: true,
Wait: true,
Timeout: 10 * time.Minute,
ValuesOptions: values.Options{Values: []string{"global.env_vars.AIRBYTE_INSTALLATION_ID=" + userID.String()}},
ValuesYaml: "global:\n edition: \"test\"\n",
ValuesOptions: values.Options{Values: []string{
"global.env_vars.AIRBYTE_INSTALLATION_ID=" + userID.String(),
"global.jobs.resources.limits.cpu=3",
"global.jobs.resources.limits.memory=4Gi",
}},
ValuesYaml: "global:\n edition: \"test\"\n",
},
release: release.Release{
Chart: &chart.Chart{Metadata: &chart.Metadata{Version: "1.2.3.4"}},
Expand Down

0 comments on commit 1319dd5

Please sign in to comment.