Add --check, --no-error-on-fix flags #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ovsds
commented
Jan 8, 2024
.pre-commit-config.yaml
Outdated
| @@ -4,11 +4,11 @@ repos: | |||
| hooks: | |||
| - id: autopep8 | |||
| - repo: https://github.com/PyCQA/isort | |||
| rev: '5.10.1' | |||
| rev: '5.13.2' | |||
There was a problem hiding this comment.
Had to update problematic versions to avoid errors on pre-commit
ovsds
commented
Jan 8, 2024
Comment on lines
+190
to
+195
| parser.add_argument("--check", action="store_true") | ||
| parser.add_argument("--no-error-on-fix", action="store_true") |
There was a problem hiding this comment.
Can also provide some minimal Readme.md to reflect changes
Fix pre-commit versions
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #62 +/- ##
==========================================
- Coverage 80.14% 76.76% -3.39%
==========================================
Files 1 1
Lines 136 142 +6
==========================================
Hits 109 109
- Misses 27 33 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
asvetlov
approved these changes
Oct 30, 2024
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix pre-commit versions
What do these changes do?
Adds flow control to enable dry-run and disable errors on fix
Are there changes in behavior for the user?
User gets control over linting flow using flags
Related issue number
Fixes #61
Checklist