-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test coverage for accessing StaticResource._routes #9975
Conversation
#9911 optimized this to only build the set once, however ``aiohttp-cors`` relies on being able to mutate this at runtime https://github.com/aio-libs/aiohttp-cors/blob/38c6c17bffc805e46baccd7be1b4fd8c69d95dc3/aiohttp_cors/urldispatcher_router_adapter.py#L187
Probably a better fix is to keep the change in #9911 and add OPTIONS on |
CodSpeed Performance ReportMerging #9975 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9975 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 121 121
Lines 36714 36727 +13
Branches 4383 4383
=======================================
+ Hits 36248 36261 +13
Misses 314 314
Partials 152 152
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport to 3.11: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 8704bc7 on top of patchback/backports/3.11/8704bc74f127497496d4e3241304a6f6d2346494/pr-9975 Backporting merged PR #9975 into master
🤖 @patchback |
Backport to 3.12: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 8704bc7 on top of patchback/backports/3.12/8704bc74f127497496d4e3241304a6f6d2346494/pr-9975 Backporting merged PR #9975 into master
🤖 @patchback |
(cherry picked from commit 8704bc7)
(cherry picked from commit 8704bc7)
#9911 optimized this to only build the set once, however
aiohttp-cors
relies on being able to accessStaticResouce._routes
https://github.com/aio-libs/aiohttp-cors/blob/38c6c17bffc805e46baccd7be1b4fd8c69d95dc3/aiohttp_cors/urldispatcher_router_adapter.py#L187 so it was reverted in #9972
Since this requirement is unexpected, and therefore hard to discover, add a test for it.