Revert "Only construct the allowed_methods set once for a `Static…

…Resource`" (#9972)
aio-libs · Nov 19, 2024 · 9916d32 · 9916d32
1 parent 4e8324e
commit 9916d32
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/CHANGES/9972.bugfix.rst b/CHANGES/9972.bugfix.rst
@@ -0,0 +1,3 @@
+Reverted an optimization to avoid rebuilding the allowed methods for ``StaticResource`` on every request -- by :user:`bdraco`.
+
+``aiohttp-cors`` needs to be able to modify the allowed methods at run time via this internal.
diff --git a/aiohttp/web_urldispatcher.py b/aiohttp/web_urldispatcher.py
@@ -557,7 +557,6 @@ def __init__(
                 "HEAD", self._handle, self, expect_handler=expect_handler
             ),
         }
-        self._allowed_methods = set(self._routes)
 
     def url_for(  # type: ignore[override]
         self,
@@ -624,7 +623,7 @@ async def resolve(self, request: Request) -> _Resolve:
         if not path.startswith(self._prefix2) and path != self._prefix:
             return None, set()
 
-        allowed_methods = self._allowed_methods
+        allowed_methods = set(self._routes)
         if method not in allowed_methods:
             return None, allowed_methods