Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing network methods to ain-js #160

Merged
merged 5 commits into from
Mar 22, 2024
Merged

Add missing network methods to ain-js #160

merged 5 commits into from
Mar 22, 2024

Conversation

platfowner
Copy link
Member

Change summary:

  • Add getChainId() method
  • Add getConsensusStatus() method
  • Add getRawConsensusStatus() metod
  • Add getPeerCandidateInfo() method
  • Fix test endpoint port number

Related issues:

jiyoung-an
jiyoung-an approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@jiyoung-an jiyoung-an left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some questions, thanks!

src/net.ts Show resolved Hide resolved
src/net.ts Show resolved Hide resolved
@platfowner
Copy link
Member Author

Thanks for the review! @jiyoung-an Now merging..

minsulee2
minsulee2 approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@minsulee2 minsulee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@platfowner platfowner mentioned this pull request Mar 22, 2024
Closed
@platfowner platfowner merged commit bc4b46a into develop Mar 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiyoung-an jiyoung-an jiyoung-an approved these changes

@minsulee2 minsulee2 minsulee2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@platfowner @minsulee2 @jiyoung-an