Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing Blockchain Node APIs to ain-js #159

Merged
merged 4 commits into from
Mar 5, 2024
Merged

Add missing Blockchain Node APIs to ain-js #159

merged 4 commits into from
Mar 5, 2024

Conversation

platfowner
Copy link
Member

Change summary:

  • Split getProposer() to getProposerByNumber() and getProposerByHash()
  • Split getValidators() to getValidatorsByNumber() and getValidatorsByHash()
  • Add getValidatorInfo() method

Related issues:

jiyoung-an
jiyoung-an reviewed Mar 4, 2024
View reviewed changes
src/ain.ts Outdated
}

/**
* Fetches the forger's address of a block with a block number.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question) what is forger?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sometimes block proposer is called block forger or block producer. just replaced with 'block proposer' for readability. thanks!

@jiyoung-an
Copy link
Member

LGTM with some question!

@platfowner
Copy link
Member Author

Thanks for the review! @jiyoung-an Now merging..

@platfowner platfowner merged commit ad139d6 into develop Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiyoung-an jiyoung-an jiyoung-an approved these changes

@minsulee2 minsulee2 Awaiting requested review from minsulee2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@platfowner @jiyoung-an