Allow only positive transfer values #153
Conversation
platfowner
requested review from
woomurf,
shyun-comcom,
minsulee2,
jiyoung-an,
minjaeli,
YunsuBae and
akastercomcom
| @@ -256,6 +256,9 @@ export default class Wallet { | |||
| transfer(input: {to: string, value: number, from?: string, nonce?: number, gas_price?: number}, isDryrun: boolean = false): Promise<any> { | |||
| const address = this.getImpliedAddress(input.from); | |||
| const toAddress = Ain.utils.toChecksumAddress(input.to); | |||
| if (!(input.value > 0)) { | |||
There was a problem hiding this comment.
Is there any reason to check value is positive number? I know, If value is 0 or negative number, blockchain will throw error.
There was a problem hiding this comment.
Right, this saves user's tx fee though.
There was a problem hiding this comment.
Oh, if the transaction fails, does the user still have to pay the transaction fee?
There was a problem hiding this comment.
That's a good quesiton.
It depends on the conditions the transaction breaks.
If the're prechecks or skipFees = true, tx fee is not charged (see https://github.com/ainblockchain/ain-blockchain/blob/master/db/index.js#L1955).
Basically, for the failed transactions included in blocks, tx fee is charged.
It's for handling dos attacks using failed transactions.
There was a problem hiding this comment.
Thank you for the detailed explanation!
|
Thanks for the review! @woomurf Now merging.. |
Change summary:
Related issues: