Allow up to 6 decimals in transfer values #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
platfowner
requested review from
woomurf,
shyun-comcom,
minsulee2,
jiyoung-an,
akastercomcom,
minjaeli and
YunsuBae
jiyoung-an
approved these changes
Oct 20, 2023
__tests__/ain.test.ts
Outdated
| expect(Wallet.countDecimals(100001)).toBe(0); | ||
| expect(Wallet.countDecimals(1000001)).toBe(0); | ||
| expect(Wallet.countDecimals(10000001)).toBe(0); | ||
| expect(Wallet.countDecimals(100000001)).toBe(0); |
There was a problem hiding this comment.
Q. What does these test cases mean? (11, 101, ..., 100000001)
There was a problem hiding this comment.
This is '1.00000001e8' case.
__tests__/ain.test.ts
Outdated
| expect(Wallet.countDecimals(1.0000003)).toBe(7); | ||
| expect(Wallet.countDecimals(1.00000003)).toBe(8); | ||
| expect(Wallet.countDecimals(1.000000003)).toBe(9); | ||
| expect(Wallet.countDecimals(1.0000000003)).toBe(10); |
There was a problem hiding this comment.
minor) How about adding test cases in the 'e-' format?
There was a problem hiding this comment.
0.0000000012 is actually '1.2e-9' case. toString() converts 0.0000000012 to '1.2e-9'.
There was a problem hiding this comment.
Just added toString() results as comments. Thanks!
|
Thanks for the review! @jiyoung-an Now merging.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary:
Related issues: