Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video fix #16

Merged
merged 6 commits into from
Sep 6, 2024
Merged

Video fix #16

merged 6 commits into from
Sep 6, 2024

Conversation

Rainiefantasy
Copy link
Contributor

@Rainiefantasy Rainiefantasy commented Sep 6, 2024

Addresses #10

Quality of .mov file was lowered too much, was a bit blurry, and link had broken so needed a fix.

Proposed Changes

  1. Converted .mov file into gif using ffmpeg
  2. Added gif to the home folder
  3. added gif link ref in the readme

Checklist before review:

  • Are you happy with the gif file being in the main folder? if not can move it
  • check if it works for you

@Rainiefantasy Rainiefantasy self-assigned this Sep 6, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 6, 2024
@RayStick RayStick self-requested a review September 6, 2024 10:43
README.md Outdated
@@ -40,7 +40,7 @@ We include information on [CPRD's Code Browser tool](cprd-code-browser.md) and h

The [code-for-aurum](code-for-aurum) folder uses `Python` and `postgreSQL` to create a pre-processing workflow for CPRD Aurum data which includes a conversion of data file format for compatibility, and then reading the data into tables in a relational database. Workbooks have been created to familiarise a user with the CPRD Aurum tables, including how they link together and how to build a sample cohort:

https://github.com/user-attachments/assets/9a636d4c-8170-4145-b6fc-60ac0f4c16d1
![landing-page-demo-gif](https://github.com/aim-rsf/cprd-data-wrangle/blob/video-fix/output.gif?raw=true)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
![landing-page-demo-gif](https://github.com/aim-rsf/cprd-data-wrangle/blob/video-fix/output.gif?raw=true)
![landing-page-demo-gif](https://github.com/aim-rsf/cprd-data-wrangle/blob/video-fix/notebook_demo.gif?raw=true)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we rename the .gif file to something clearer like 'notebook_demo.gif'?
If that works for you, please change the name of the gif file :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I changed it manually - I could've just commited XD ah well

README.md Outdated Show resolved Hide resolved
@RayStick
Copy link
Member

RayStick commented Sep 6, 2024

This looks great! Such an improvement. Thanks for working on it

Two suggestions for you to implement (via 'commit suggestion' and also file name change) - after that, happy for you to merge it!

@Rainiefantasy
Copy link
Contributor Author

I've committed your suggestion for readme changes - I realise I preemptively changed the filename after reading your suggestion when I could've committed your suggestion instead sorry!

@Rainiefantasy Rainiefantasy merged commit f893f66 into main Sep 6, 2024
1 check passed
Copy link

welcome bot commented Sep 6, 2024

🎉 Congrats on merging your first pull request in this repo! We appreciate your contribution!

@Rainiefantasy Rainiefantasy deleted the video-fix branch September 6, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants