Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md for code authors/reviewers #106

Merged
merged 6 commits into from
Jul 22, 2024

Conversation

RayStick
Copy link
Member

@RayStick RayStick commented Jul 22, 2024

Closes #103

@Rainiefantasy do you think these steps are correct and sufficient to guide someone through that process? Based on your experience recently, reviewing PRs

@BatoolMM would appreciate your perspective here too, considering your experience with git and R

Checklist before review:

  • Please comment on my PR while it's a draft and give me feedback on the development!
  • I added everything I wanted to add to this PR, please review!
  • The title of this PR is clear and self-explantory.
  • I added any appropriate labels to this PR.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 22, 2024
Copy link
Member

@BatoolMM BatoolMM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks very good to me - very minor suggestion, feel free to ignore.
The guidelines seem to be for RStudio users, so I added a few notes.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@RayStick RayStick marked this pull request as ready for review July 22, 2024 11:06
Copy link
Contributor

@Rainiefantasy Rainiefantasy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! minor comment but otherwise reflects my experience in testing the R package well. :)

CONTRIBUTING.md Show resolved Hide resolved
@RayStick RayStick merged commit 583bb4b into main Jul 22, 2024
2 checks passed
@RayStick RayStick deleted the update-code-contributors branch July 22, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating contribution doc to include info on syncing R with GitHub branches
3 participants