-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CONTRIBUTING.md for code authors/reviewers #106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks very good to me - very minor suggestion, feel free to ignore.
The guidelines seem to be for RStudio users, so I added a few notes.
Co-authored-by: Batool Almarzouq <[email protected]>
Co-authored-by: Batool Almarzouq <[email protected]>
Co-authored-by: Batool Almarzouq <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! minor comment but otherwise reflects my experience in testing the R package well. :)
Closes #103
@Rainiefantasy do you think these steps are correct and sufficient to guide someone through that process? Based on your experience recently, reviewing PRs
@BatoolMM would appreciate your perspective here too, considering your experience with git and R
Checklist before review: