-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move kiwipy/rmq related modules into a specific module #297
Draft
unkcpz
wants to merge
13
commits into
aiidateam:dev
Choose a base branch
from
unkcpz:rmq-out
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #297 +/- ##
======================================
Coverage ? 90.20%
======================================
Files ? 26
Lines ? 3051
Branches ? 0
======================================
Hits ? 2752
Misses ? 299
Partials ? 0 ☔ View full report in Codecov by Sentry. |
unkcpz
force-pushed
the
rmq-out
branch
4 times, most recently
from
December 14, 2024 23:22
156d81a
to
fc52fcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refactoring is targeting to decouple the dependencies of using kiwipy+rmq as the communicator for the process control.
One of the major change here is hand write the resolver of future by mimic how tho asyncio does for wrapping
concurrent.futures.Future
intoasyncio.Future
. I use the same way to convertasyncio.Future
intoconcurent.futures.Future
(which is thekiwipy.Future
as alias).aio_pika
import lazily by moving the rmq exceptions tormq
module, this can increase the performance ofimport aiida; aiida.orm
.CancellableAction
using composite to behave as a Future like object.asyncio.Future
in favor of aliasplumpy.Future
andconcurrent.futures.Future
instead of aliaskiwipy.Future
._chain
and_copy_future
since we can not just rely on the API of asyncio that is not exposed.coordinator/Communicator
protocol.coordinator/Coordinator
protocol and wrap rmq/communicator as a coordinator that not require changs in kiwipy.