Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deabstract states #290

Closed
wants to merge 27 commits into from
Closed

Deabstract states #290

wants to merge 27 commits into from

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Nov 28, 2024

The states have convoluted inheritance relations. This is an attempt to use persistence.Savable as composition and state_machine.State as class contract/protocol.

unkcpz added 25 commits November 27, 2024 13:59
@unkcpz
Bump version for pytest and pytest tools
a56887f
@unkcpz
Use ruff and use aiida-core ruff config
c2e6298
@unkcpz
test/utils.py
92424ed
@unkcpz
test/test_workchain.py
9e5c1ad
@unkcpz
test/test_processes.py
db7289b
@unkcpz
test_process comms/spec .py
bc58b36
@unkcpz
test_lang.py and test_port.py
8c57147
@unkcpz
test_expose.py
e610aba
@unkcpz
test_communicator.py / test_process_comms.py
86667a6
@unkcpz
test_inmemory.py / test_pickle.py
047a830
@unkcpz
workchains ruff fix
dacf8a9
@unkcpz
process_comms.py / process_states.py
6b31928
@unkcpz
state_machine.py lang.py loaders.py
734e37f
@unkcpz
Address mypy complains
deb4ad7
@unkcpz
quickfix for accidentlly removed execute expression
6e89d81
@unkcpz
Remove all pylint s
e6da5bd
@unkcpz
Bump ruff to 0.8.0 for sort the imports
ca8afca
@unkcpz
Update python version to 3.12 for pre-commit CI
5e89e46
@unkcpz
Double quotes for eval inside single quotes f-strings
7896a05
@unkcpz
workaround for aio-pika/issues/649
4150816
@unkcpz
qf
8c7b0c4
@unkcpz
Update mypy to 1.13.0
e60278f
@unkcpz
Waiting state directly from state_machine.state and persistence.Savable
fb43887
@unkcpz
Remove super_check for both load/save instance_state methods
4aef7e4
@unkcpz
StateMachine parts removed out (almost)
684cc07
@unkcpz unkcpz marked this pull request as draft November 28, 2024 15:21
@unkcpz
Copy link
Member Author

unkcpz commented Dec 11, 2024

This will be replaced by another branch.

@unkcpz unkcpz closed this Dec 11, 2024
@unkcpz unkcpz deleted the deabstract-states branch December 11, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@unkcpz