Merge changes from v0.21.9 and v0.21.10
#279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the new required `build.os` key and fix it to Ubuntu 22.04 Cherry-pick: 31f85c7
The `ProcessListener` is made persistable by deriving it, as well as the `EventHelper` class from `persistence.Savable`. The class `EventHelper` is moved to a new file because of a circular import that would result between the `utils` and `persistence` modules. There was a circular reference issue in the test listener that was storing a reference to the process inside it, making its serialization impossible. To fix the tests an ugly hack was used: storing the reference to the process outside the class in a global dict using id as keys. Some more ugly hacks were needed to correctly check the equality of two processes. Instances having different listeners should be ignored. Cherry-pick: 98a375f
In `Process.on_entered`, the `Communicator.broadcast_send` method is called to broadcast the state change to subscribers over RabbitMQ. This can throw a `ChannelInvalidStateError` in addition to the `ConnectionClose` exception that was already being caught, in case there is a problem with the connection. Cherry-pick: db2af9a
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #279 +/- ##
==========================================
- Coverage 90.83% 90.73% -0.09%
==========================================
Files 21 22 +1
Lines 2974 2996 +22
==========================================
+ Hits 2701 2718 +17
- Misses 273 278 +5
☔ View full report in Codecov by Sentry. |
sphuber
force-pushed
the
fix/merge-support
branch
2 times, most recently
from
1971c6d to
4633466
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.